Python: Split type checkers by target (pyright source, 5 checkers on tests/samples)#6443
Merged
Merged
Conversation
eavanvalkenburg
force-pushed
the
typing_exp
branch
from
June 10, 2026 08:40
f2be487 to
31c4b66
Compare
eavanvalkenburg
force-pushed
the
typing_exp
branch
from
June 15, 2026 14:00
31c4b66 to
30ee0b6
Compare
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 14:00 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 14:00 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 14:45 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 14:45 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 15:02 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 15:02 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 15:11 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
integration
June 15, 2026 15:11 — with
GitHub Actions
Inactive
eavanvalkenburg
marked this pull request as ready for review
June 15, 2026 17:11
eavanvalkenburg
force-pushed
the
typing_exp
branch
from
June 17, 2026 12:36
a1f1cb3 to
c4f767f
Compare
eavanvalkenburg
enabled auto-merge
June 17, 2026 14:58
moonbox3
approved these changes
Jun 18, 2026
eavanvalkenburg
force-pushed
the
typing_exp
branch
from
June 18, 2026 06:59
eab83dc to
5462332
Compare
westey-m
approved these changes
Jun 18, 2026
westey-m
approved these changes
Jun 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jun 18, 2026
…tests/samples) Rework the typing setup along the lines of the 'too many type checkers' approach: - Pyright (strict) is now the sole source-code type checker; mypy is removed from source and its [tool.mypy] block becomes a relaxed profile used only for tests/samples. - Tests are checked by all five checkers (pyright relaxed, mypy, pyrefly, ty, zuban); samples by pyright, pyrefly, and ty. All run in a relaxed/ basic profile so authors aren't forced into over-annotation. - Add pyrightconfig.tests.json and bump sample pyright configs to basic. - Unify test/sample typing onto the same parallel fan-out used by source pyright via run_command_items in task_runner.py. - Make version-conditional imports symmetric: keep or drop the '# type: ignore' on both branches so results match across interpreter versions (local vs CI). - Update SKILL.md, DEV_SETUP.md, and CODING_STANDARD.md for the five gating checkers and pyright on source+tests+samples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merging main into the type-checker split branch surfaced regressions that
the new five-checker test suite and unit tests caught:
Runtime fixes:
- anthropic: restore the dropped `cache_read_input_token_count` mapping in
_parse_usage_from_anthropic (lost during merge conflict resolution).
- gemini: _get_function_calling_mode test helper returned str(enum)
('FunctionCallingConfigMode.AUTO') instead of the enum value ('AUTO').
- openai: _response_id_from_token test helper was an infinite self-recursion;
return token['response_id'].
- orchestrations: reset output_events per approval iteration so the terminal
output assertion counts only the final run.
- core: drop a stale duplicate harness test whose message ('non-negative')
contradicted the source ('positive').
- purview: import PolicyLocation/PolicyScope/ProtectionScopeActivities/
ExecutionMode used by the processor tests.
Type-checker fixes (tests, relaxed profile):
- core: pyright/mypy/pyrefly/ty/zuban green-ups across the harness, MCP,
observability and types tests.
- anthropic/openai: route provider-namespaced UsageDetails keys through a
dict cast (extra_items TypedDict unsupported by mypy/ty).
- purview: typed model constructors and cache-mock casts.
- ag-ui: annotate WorkflowContext[Any, Any] so yield_output accepts test
payloads, guard Optional forwarded_props, and ty-ignore intentional bad args.
Source pyright (sole source checker) flagged unnecessary ignores newly
introduced by merged code in core _tools.py and declarative _declarative_base.py.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The parallel test-typing fan-out runs many mypy processes concurrently, all defaulting to a single shared ./.mypy_cache. Concurrent writes corrupt the cache and mypy aborts with INTERNAL ERROR (intermittently, depending on worker timing) -- which is why CI's Test Typing job failed on a shifting set of packages while a single-package run was fine. Give each mypy invocation an isolated cache dir keyed by its target paths so incremental caching still works per package without races. Other checkers (zuban/pyrefly/ty/pyright) maintain their own caches and are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Lab was the last package still running mypy on its source code, requiring mypy-only `# type: ignore` comments that pyright (the sole source checker everywhere else) flags as unnecessary. Align lab with the rest of the monorepo: - Remove the lab source mypy poe tasks (mypy-gaia/lightning/tau2) and the now-dead strict [tool.mypy] config block. - Drop the 'Run lab mypy' CI step; lab source is type-checked by pyright only. Lab tests remain covered by the workspace test-typing fan-out (mypy, pyrefly, ty, zuban, pyright over tests using the relaxed root config). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A fresh merge from main brought in new test code never run under the
five-checker test-typing suite. Green up across the affected packages:
- core: narrow Optional span.attributes with 'and' guards in span filters
and assert+cast the json.loads(...attributes[...]) reads (test_observability);
match the existing as_agent ignore on the protocol-typed fixture (test_clients).
- openai: align new streaming tests with the established chat_options dict
pattern (ChatOptions TypedDict isn't assignable to dict), route Optional
.annotations[0] access through a small _first_annotation helper (mirrors the
file's assert-not-None convention), and annotate a mapped ResponseStream.
- foundry_hosting: annotate error: dict[str, Any] = body.get(...) or {}
(zuban needs the annotation).
- foundry: narrow ignores for the live AIProjectClient credential arg (pyrefly)
and connections.get_default (zuban) SDK type gaps.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eavanvalkenburg
force-pushed
the
typing_exp
branch
from
June 18, 2026 10:22
865d5ef to
09e3ec1
Compare
eavanvalkenburg
enabled auto-merge
June 18, 2026 10:28
westey-m
approved these changes
Jun 18, 2026
Pyright 1.1.410 tightened several checks. Apply the same source fixes as upstream PR microsoft#6275: - anthropic: import AsyncAnthropicBedrock from anthropic.lib.bedrock and AsyncAnthropicVertex from anthropic.lib.vertex (no longer re-exported from the anthropic top-level package -> reportPrivateImportUsage). - core _types.py: cast the transform-hook result to UpdateT (reportAssignmentType). - core _workflows/_events.py: annotate the @contextmanager helper as Generator[None] instead of Iterator[None] (reportDeprecated). - redis: build the combined filter expression with an explicit loop instead of reduce(and_, ...), which pyright could no longer fully type (drops the now unused functools.reduce / operator.and_ imports). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
westey-m
approved these changes
Jun 18, 2026
The workflow_orchestrator already accepts plain strings as well as JSON objects via context.get_input(), but the start_workflow_orchestration HTTP handler only accepted JSON and returned 400 for any non-JSON body. This made the functions integration tests that POST text/plain to /api/workflow/run (e.g. test_09_workflow_shared_state) fail consistently with 400 != 202. Fall back to the raw request body (decoded as UTF-8) when the body is not JSON, rejecting only a truly empty body. The JSON path is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eavanvalkenburg
enabled auto-merge
June 18, 2026 14:01
westey-m
approved these changes
Jun 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following the "too many type checkers"
approach, this reworks our typing setup so that each target is checked by the
right tool(s):
annotation burden and producing checker-specific friction on internal code.
actually call the public API only surfaced downstream.
The goal: make source development easier (one source checker) while giving
customers more confidence that running any of the five common type checkers
against their own code will surface fewer surprises.
Description
MyPy is removed from source; its
[tool.mypy]block becomes a relaxedprofile used only for tests/samples.
ty, and zuban.
script-style sample layouts).
not-required
TypedDictaccess, untyped test bodies) so test/sample authorsaren't forced into ugly over-annotation. Narrow, rule-specific ignores
(
# pyright: ignore[rule],# type: ignore[code]) are used only where achecker is pedantic.
pyrightconfig.tests.json; bumped sample pyright configs tobasic.pyrefly.toml,pyrefly.samples.toml,ty.samples.toml.pyright (
run_command_itemsinscripts/task_runner.py) for consistentexecution.
# type: ignoreis now keptor dropped on both branches, so results match across interpreter versions
(local vs CI) instead of only matching the current venv.
SKILL.md,DEV_SETUP.md, andCODING_STANDARD.mdfor the fivegating checkers and pyright over source + tests + samples.
Contribution Checklist